fix: set composer size to current canvas output size#296
fix: set composer size to current canvas output size#296ynamite wants to merge 1 commit intopmndrs:masterfrom ynamite:master
Conversation
get current canvas output size and set composer size to this. Required to work with Drei's View.tsx, see
ynamite
changed the title
|
@ynamite Why was this PR closed? I noticed that when using EffectComposer inside View, the canvas does not update to the correct size when I resize the browser window (e.g. by clicking the maximize/restore button). At first, I thought it was an R3F issue, but when I commented out the EffectComposer in View, the canvas updated correctly. I found this issue and I believe this PR could solve my problem, but I saw that it was closed. Could you please share the reason why? |
|
@mcu13321 strange, I don‘t recall deleting the repository. May have been a mistake on my part. But it was just a few added lines of code anyway. I loosely recall someone else having made a similar pull request that was closed by the maintainers. That may have been my rationale for deleting it, but not sure. |
|
Yes, by adding the code from this PR, I was able to solve the issue. The solution works, but I’m not sure why it wasn’t merged. |
|
@mcu13321 sorry I was on vacation for a couple of days. Are you open to creating a PR yourself? |
|
I’ve submitted the PR and hope it can be approved. #341 |
2 participants
get current canvas output size and set composer size to this. Required to work with Drei's View.tsx, see #285